feat: Add get_feature_flags_result method to client#89
Merged
dustinbyrne merged 2 commits intomainfrom Jan 28, 2026
Merged
Conversation
f91a3f2 to
2a7fdce
Compare
dmarticus
approved these changes
Jan 27, 2026
Contributor
dmarticus
left a comment
There was a problem hiding this comment.
Generally great; Ruby is a fun language! I liked the factory method and FeatureFlagResult design in general, and the O(n) -> O(1) optimization is a nice bonus.
49612a3 to
2a7fdce
Compare
This method returns flag evaluation results including enabled, variant, payload. It replaces cases where a flag must be checked before making a second call to retrieve its payload.
2a7fdce to
3253540
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_feature_flag_resultmethod that returns aFeatureFlagResultobject containing enabled state, variant, and payload in a single callget_feature_flag_payloadin favor of the new unified methodget_feature_flagfrom O(n) to O(1) by using the existing@feature_flags_by_keyhashMotivation
Previously, getting a flag's value and payload required two separate calls:
The new method returns both in one call:
Related to PostHog/posthog#43520